Hi, has anyone successfully deployed Phoenix using ArgoCD + Helm? For some reason the Phoenix deployment is configured with Helm hook annotations ("helm.sh/hook": pre-install,pre-upgrade - https://github.com/Arize-ai/phoenix/blob/main/helm/templates/phoenix/deployment.yaml#L13-L15), and this means that ArgoCD treat it as a PreSync hook and so will deploy this prior to any other resources, and it will fail to start because it doesn't yet have configmaps, and then it will be deleted anyway because it is a hook! (https://argo-cd.readthedocs.io/en/stable/user-guide/sync-waves/#hook-lifecycle-and-cleanup). I don't see why the deployment has these annotations at all, so should I just submit a PR to delete them?
You are correct: the Helm hook annotations (helm.sh/hook: pre-install,pre-upgrade) on the Phoenix deployment cause ArgoCD to treat the deployment as a hook, which leads to the issues you described (early deployment, missing dependencies, and deletion after execution). These annotations are not necessary for the Phoenix deployment and have been identified as problematic for tools like ArgoCD and Pulumi. The Phoenix maintainers have discussed their removal, noting that the hooks do not achieve their intended purpose and can safely be deleted. Submitting a PR to remove these annotations is appropriate and aligns with recent community feedback and open PRs addressing this exact issue (see discussion and PR).Would you like more detail on the technical background or guidance on submitting the PR?Sources:
- Phoenix deployment.yaml with hook annotations
- ArgoCD hook lifecycle and cleanup
- Phoenix PR: remove hook annotations
馃挕聽Hint: Mention RunLLM in the thread for followups.
Thanks - I've moved my comment there.
Should be out momentarily https://github.com/Arize-ai/phoenix/pull/9486
